Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new test report format: HTML #1750

Merged
merged 18 commits into from
May 24, 2024

Conversation

depapp
Copy link
Contributor

@depapp depapp commented May 20, 2024

Proposed Changes

My team and I - @fitriahfebriani @dhanifatima @akbarb83 - are working on creating a new test report format using HTML.
This feature was also requested in the GitHub issue and Slack channel:

Testing

To use the HTML test report: maestro test --format html flow.yaml

Test Report

  • The test report is available in the /Users/user/.maestro/tests/*/report.html directory

Maestro - HTML Test Report html

@axelniklasson axelniklasson self-requested a review May 20, 2024 11:43
@axelniklasson axelniklasson self-assigned this May 20, 2024
@axelniklasson axelniklasson added external-contribution enhancement New feature request or improvement of an existing feature labels May 20, 2024
@axelniklasson
Copy link
Collaborator

@depapp thanks to you and the team for taking the time to work on an HTML report generation! Did you consider using something like Allure for the rendering instead of building the reporting from scratch?

@ludovicobesana
Copy link

@depapp Nice idea and congrats for the work! I was working on that too the last week 🚀

Screenshot 2024-05-13 alle 13 06 55
Screenshot 2024-05-13 alle 13 07 24

@depapp
Copy link
Contributor Author

depapp commented May 21, 2024

@depapp thanks to you and the team for taking the time to work on an HTML report generation! Did you consider using something like Allure for the rendering instead of building the reporting from scratch?

hi @axelniklasson thanks for your feedback,

using Allure is a great idea. but I think we could implement it as an additional format option in a separate Pull Request,
so the command looks like --format allure, so there would be three options available:

  • junit
  • html
  • allure

this would be similar to other automation tools.

@depapp
Copy link
Contributor Author

depapp commented May 21, 2024

@depapp Nice idea and congrats for the work! I was working on that too the last week 🚀

hi @ludovicobesana 👋🏻

it's great to hear that you were working on this as well.
let's collaborate and combine our efforts to make the HTML report feature even better. 🚀

@depapp
Copy link
Contributor Author

depapp commented May 24, 2024

hi @axelniklasson
could you please assist with re-reviewing the changes
thanks

updated report:
image

@depapp depapp requested a review from axelniklasson May 24, 2024 07:48
Copy link
Collaborator

@axelniklasson axelniklasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits regarding copy but apart from that it's looking great! 🙌

depapp and others added 2 commits May 24, 2024 17:30
…rter.kt

Co-authored-by: Axel Niklasson <axel.r.niklasson@gmail.com>
Co-authored-by: Axel Niklasson <axel.r.niklasson@gmail.com>
@depapp
Copy link
Contributor Author

depapp commented May 24, 2024

A couple of nits regarding copy but apart from that it's looking great! 🙌

thanks @axelniklasson 🙇🏻
I will update the documentation soon as well

@axelniklasson
Copy link
Collaborator

Thanks for this contribution @depapp 🙏 Please tag me in the docs PR when you've raised it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants