rhel/centos support #150

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@rurban
rurban commented Apr 11, 2012
  1. define HAVE_BSWAP_64 for byteorder.h and bswap_64 macros on redhat and centos (DONE)
  2. pipe2 O_CLOEXEC undefined on centos (DONE)
  3. boost/typeof/typeof.hpp missing on boost-devel-1.33.1-15.el5.i386 (DONE)
@ryansch
ryansch commented Apr 11, 2012

Just hit my head on this. Waiting with baited breath.

rurban added some commits Apr 11, 2012
@rurban rurban rhel/centos byteorder.h support
define HAVE_BSWAP_64 for byteorder.h and bswap_64 macros on redhat and centos
da1a5ab
@rurban rurban rhel: add O_CLOEXEC check to pipe2 check for libstddjb
O_CLOEXEC is defined in fcntl.h
Older rhel kernels do not support O_CLOEXEC. undef HAVE_PIPE2 then.
c70c370
@rurban rurban Check boost-1.34 for BOOST_AUTO
AC_CHECK_HEADER([boost/typeof/typeof.hpp] ...
unfortunately does not use the boost specific CXXFLAGS
b38c381
@rurban
rurban commented Apr 11, 2012

Tested okay, even with old boost (1.33) in /usr/include and new boost (1.34) in /usr/local/include

@rurban rurban closed this Apr 11, 2012
@rurban rurban reopened this Apr 11, 2012
@ryansch
ryansch commented Apr 12, 2012

I was able to build an rpm on a stock amazon linux AMI from the fedora spec. Thanks!

@mitchblank

Ah, I separately hit the boost 1.34 thing and opened issue #154 on that before I saw this pull request.

It looks like I just duplicated the work you did getting it to compile on a CentOS box.. your byteorder changes are better than the hacks I did though so no need for me to submit those.

@ryansch
ryansch commented Apr 13, 2012

@rurban This pull request has gotten messy with all the other activity on your master branch. You probably want to open a new one with a dedicated topic branch.

@rurban
rurban commented Apr 13, 2012

see new pull request #2 (seperate branch, and rebased)

@rurban rurban closed this Apr 13, 2012
@ryansch
ryansch commented Apr 13, 2012

See #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment