rhel/centos support #150
Closed
rhel/centos support #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurban
commented
Apr 11, 2012
rurban
commented
- define HAVE_BSWAP_64 for byteorder.h and bswap_64 macros on redhat and centos (DONE)
- pipe2 O_CLOEXEC undefined on centos (DONE)
- boost/typeof/typeof.hpp missing on boost-devel-1.33.1-15.el5.i386 (DONE)
|
Just hit my head on this. Waiting with baited breath. |
added 3 commits
April 11, 2012 13:20
define HAVE_BSWAP_64 for byteorder.h and bswap_64 macros on redhat and centos
O_CLOEXEC is defined in fcntl.h Older rhel kernels do not support O_CLOEXEC. undef HAVE_PIPE2 then.
AC_CHECK_HEADER([boost/typeof/typeof.hpp] ... unfortunately does not use the boost specific CXXFLAGS
|
Tested okay, even with old boost (1.33) in /usr/include and new boost (1.34) in /usr/local/include |
|
I was able to build an rpm on a stock amazon linux AMI from the fedora spec. Thanks! |
|
Ah, I separately hit the boost 1.34 thing and opened issue #154 on that before I saw this pull request. It looks like I just duplicated the work you did getting it to compile on a CentOS box.. your byteorder changes are better than the hacks I did though so no need for me to submit those. |
|
@rurban This pull request has gotten messy with all the other activity on your master branch. You probably want to open a new one with a dedicated topic branch. |
|
see new pull request #2 (seperate branch, and rebased) |
|
See #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.