Remove system("locale") calls. #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The locale command is not available on many systems. As this variable is unused and appears to have been written with the intent of displaying the locale settings to the user, it's not really necessary. As this breaks Mosh on a lot of systems, it's best to remove the calls. Signed-off-by: Christian Stewart <christian@paral.in>
|
Please see comment at #650 (comment) Hard for me to believe this "breaks Mosh on a lot of systems." Mosh only attempts running the command as part of a fatal error message, a missing command would be a nonfatal error, and the "locale" command is required by POSIX (since 2001). Where are you seeing a problem? |
|
See #650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locale command is not available on many systems. As this variable
is unused and appears to have been written with the intent of
displaying the locale settings to the user, it's not really necessary.
As this breaks Mosh on a lot of systems, it's best to remove the calls.