Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsvProductIdVerifier #40

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Add IsvProductIdVerifier #40

merged 1 commit into from
Mar 15, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

Motivation

Future Work

@nick-mobilecoin nick-mobilecoin requested review from a team and awygle and removed request for a team March 9, 2023 18:01
Copy link

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #40 (c3c06c5) into nick/extended-product-id (5c5209d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@                     Coverage Diff                      @@
##           nick/extended-product-id      #40      +/-   ##
============================================================
+ Coverage                     95.54%   95.65%   +0.10%     
============================================================
  Files                             2        2              
  Lines                           764      783      +19     
============================================================
+ Hits                            730      749      +19     
  Misses                           34       34              
Impacted Files Coverage Δ
verifier/src/lib.rs 90.51% <ø> (ø)
verifier/src/report_body.rs 99.34% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin
Copy link
Collaborator Author

@nick-mobilecoin queued this pull request to merge with Graphite.

Base automatically changed from nick/extended-product-id to main March 14, 2023 20:59
@nick-mobilecoin
Copy link
Collaborator Author

Graphite couldn't merge this PR because it was not satisfying all requirements.

@nick-mobilecoin
Copy link
Collaborator Author

@awygle bumping for restack

@nick-mobilecoin
Copy link
Collaborator Author

@nick-mobilecoin queued this pull request to merge with Graphite.

@nick-mobilecoin nick-mobilecoin merged commit 439ff37 into main Mar 15, 2023
@nick-mobilecoin
Copy link
Collaborator Author

@nick-mobilecoin merged this pull request with Graphite.

@nick-mobilecoin nick-mobilecoin deleted the nick/isv-product-id branch March 15, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium-sized PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants