Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpacedStructName trait #47

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Mar 15, 2023

The SpacedStructName trait provides a textual representation of a
struct. Instead of the common pascal case names used in rust, it is
intended to provide a lowercase space separated name. Words or acronyms
that are capitalized will still be capitalized.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Mar 15, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@082b4c7). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage        ?   95.78%           
=======================================
  Files           ?        3           
  Lines           ?      902           
  Branches        ?        0           
=======================================
  Hits            ?      864           
  Misses          ?       38           
  Partials        ?        0           
Impacted Files Coverage Δ
verifier/src/lib.rs 90.51% <ø> (ø)
verifier/src/struct_name.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin requested review from a team and NotGyro and removed request for a team March 16, 2023 17:24
@jcape jcape requested review from a team, NotGyro and awygle and removed request for NotGyro and a team March 17, 2023 18:06
The `SpacedStructName` trait provides a textual representation of a
struct. Instead of the common pascal case names used in rust, it is
intended to provide a lowercase space separated name. Words or acronyms
that are capitalized will still be capitalized.
@nick-mobilecoin nick-mobilecoin changed the base branch from nick/verification-result to main March 17, 2023 21:02
Copy link

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation LGTM.

@nick-mobilecoin nick-mobilecoin merged commit 935c6a1 into main Mar 17, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/struct-nouns-trait branch March 17, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium-sized PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants