-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update digest and sha2 versions to 0.10 #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: it would be great to get this in upstream though, maybe we can talk to Isis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, agree with Chris that it's worth trying to get these changes upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull should be made against dalek-cryptography:curve25519-dalek, and then that upstream should be merged here.
bincode = "1" | ||
criterion = "0.3.0" | ||
hex = "0.4.2" | ||
sha2 = { version = "0.10", default-features = false } | ||
bincode = "1.3.3" | ||
criterion = "0.3.5" | ||
hex = "0.4.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all semver equivalent to my knowledge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, not the sha2 change, I don't know why that got included in the diff, just the bincode, criterion, and hex changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking I'd update the MCF forks in line with what we've been doing, then send another PR merging into upstraem dalek-crypto:master. Would that work?
Also update
bincode
,criterion
andhex
, but those are minor.Supports mobilecoinfoundation/mobilecoin#1326