Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crc from 1.8.1 to 2.0.0 #1018

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Bump crc from 1.8.1 to 2.0.0 #1018

merged 2 commits into from
Sep 20, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 17, 2021

Bumps crc from 1.8.1 to 2.0.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 17, 2021
@jcape
Copy link
Contributor

jcape commented Sep 17, 2021

@dependabot rebase

Bumps [crc](https://github.com/mrhooray/crc-rs) from 1.8.1 to 2.0.0.
- [Release notes](https://github.com/mrhooray/crc-rs/releases)
- [Commits](mrhooray/crc-rs@1.8.1...v2.0.0)

---
updated-dependencies:
- dependency-name: crc
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
jcape
jcape previously approved these changes Sep 17, 2021
@jcape jcape self-requested a review September 18, 2021 00:13
@jcape jcape self-assigned this Sep 18, 2021
@jcape jcape added this to In progress in Consensus via automation Sep 18, 2021
@jcape jcape requested review from a team and jcape and removed request for jcape September 18, 2021 01:56
Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way to know this is the correct CRC algorithm is the "jsonl" auto-generated test data is unchanged when it's correct.

@jcape jcape self-requested a review September 18, 2021 02:01
@jcape jcape dismissed their stale review September 18, 2021 02:01

Can't review my own PR ;-)

Consensus automation moved this from In progress to Review in progress Sep 18, 2021
@jcape jcape requested review from a team and removed request for jcape September 18, 2021 02:02
Consensus automation moved this from Review in progress to Reviewer approved Sep 20, 2021
@jcape jcape merged commit 75de3df into master Sep 20, 2021
@jcape jcape deleted the dependabot/cargo/crc-2.0.0 branch September 20, 2021 19:04
Consensus automation moved this from Reviewer approved to Done Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Consensus
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants