This comments out the "grafana push" part of the prometheus yml template #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate. AFAIK this grafana push hasn't been used by anyone in a few years, and it requires you to do additional setup in grafana. If you just want to talk to prometheus web interface, you have to comment this out or you get logspam. I feel like it makes sense to comment this out, but lmk if you'd rather leave it in, not a big deal.
cbeck88
requested review from
jcape,
eranrund,
a team and
NotGyro
and removed request for
a team
NotGyro
approved these changes
Feb 14, 2023
jcape
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK this grafana push stuff, for the local network script, hasn't been used by anyone in a few years, and it requires you to do additional setup in grafana. If you just want to talk to prometheus web interface, you have to comment this out or you get logspam.
I feel like it makes sense to comment this out, and let people put it back if they actually want to push from local network to grafana, but lmk if you'd rather leave it in, not a big deal.