Chore/remove temp dir #3211
Merged
Chore/remove temp dir #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeck88
approved these changes
Mar 8, 2023
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removing references to tempdir and replacing with tempfile.
All the changes are in test code or in things like test_utils.
This is a creation of #3209 not on an external fork to resolve an issue with CI.
Motivation
Tempdir is deprecated. And it is needed in order to mitigate a vulnerability in a dependency in tempdir on remove_dir_all: https://rustsec.org/advisories/RUSTSEC-2023-0018
Future Work
There will likely need to be a follow up pr to address the use of slog-gelf which also has a dependency on tempdir.
Soundtrack of this PR