This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
Fixing TimestampValidationStrategy <-> gson impcompabibility #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joselufo
approved these changes
Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to avoid lastUpdate and expiryTime to be null when parsing using gson:
For lastUpdate I've created an nullable private var and a custom getter to avoid the NullPointerException when accessing the field.
For expiryTime I changed to be an abstract member to make it possible to implement it with a custom getter instead of forcing it to be implemented as a constructor parameter.
Both changes give us the possibility to use gson without worrying about having to create a copy of the objects and assigning values each time they are parsed.