-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Get15118EVCertificateResponse.json #364
Conversation
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
@OrangeTux does that sound reasonable for you? |
to add to the explanation on the top, Hubject onboarding document with the title "Requirements for EVSEs" says this:
I cant provide the full copy of the document, unfortunately, but I hope that is enough |
I'm not sure how to handle this situation, to be fair. The OCPP 2.0.1 spec defines the limit as 5600 characters. I think this library should follow implement the specification. When the OCA makes changes to an existing spec, they should release the changes as part of a new version. For example as version 2.0.2. I'm fine with adding preliminary support for this new version. Are you aware if the OCA is planning to release these changes under a new version, @tropxy ? |
@OrangeTux this is the current plan (from the draft errata of OCPP 2.0.1 due to be released officially soon): |
@OrangeTux given this, I think we shall include this PR into the base code, what do you say? |
At Switch, we have been running into an issue in 2.0.1 where certificates for the EV included in
Get15118EVCertificateResponse
are greater than 5600 (around 5800). This is because certificates have a lot of information embedded in them which can have variable length. We know that we haven't been the only company to encounter this issue, because it has been the focus of an OCA Technology Working Group meeting in early March. The provisional conclusion at that time was to increase the limit to 7500. This hasn't been formalised in a document yet, although I know that a follow up conversation is planned (see OCA notes from that meeting below)Proposing to set to 7500 for now and then update once we get the full decision from the OCA.