Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Provide developers script they can use to get a static library versio…
…n of the iOS SDK Summary: For developers who are building apps with Automatic Reference Counting enabled using our current iOS SDK will produce errors. One solution is to provide a static library version of our SDK that they can include in their project. We could provide detailed documentation to do this but it is easier to provide a script that they can run. This diff introduces this script. We considered actually packaging the desired library with the SDK but that would involve a process change on our end because the current SDK development flow does not include building a library. So for now we will push this on the developer and perhaps in the future look at a more streamlined way to provide this library to the developer. Additionally, needed to make sure deployment target was set to iOS 3 for the project. Test Plan: In terms of testing the script just run it a few times from various initial locations, e.g. % sh /Users/caabernathy/Facebook/Code/iOS/StaticScriptTest/facebook-ios-sdk/scripts/build_facebook_ios_sdk_static_lib.sh Also run it twice to see the output library properly overwritten Once the library was produced, tested it worked well by doing the following Scenario 1: Use the library with an app that does not have ARC enabled 1/ Built a simple app with Facebook SSO and a news feed dialog 2/ Tested SSO works and that the dialog UI has all the relevant resources and works Scenario 2: Use the library with an app with ARC enabled 1/ Built a simple app with Facebook SSO and a news feed dialog. (When creating this app, made sure ARC was turned on) 2/ Tested SSO works and that the dialog UI has all the relevant resources and works Scenario 3: Switch out the Facebook SDK in the Hackbook sample app with this library 1/ Removed the FBConnect folder from the Hackbook sample app 2/ Dragged in the new library, chose to copy the contents over 3/ Ran the app and went through all the flows. Note: Found some cases that do not work that also appear to be broken in the current app, namely video upload, and recent check-ins listing. These can be addressed separately. Reviewers: yariv, jacl Reviewed By: jacl CC: mmarucheck, vijaye, selekman, brent Differential Revision: https://phabricator.fb.com/D415047 Revert Plan: OK
- Loading branch information