-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor with Python Requests #76
Conversation
I would love to get this merged, and I currently have plenty of availability to make changes if they are required. @martey what are your thoughts on this? |
Hi @mvid, Would it be possible to create a new pull request with only the changes to add Requests? This would mean not including commits like mvid/facebook-sdk@0dc3d51 or mvid/facebook-sdk@c301c00, as well as changes that introduce new unrelated functionality like mvid/facebook-sdk@fb93ff0. |
Of course. Rebasing and will push changed soon. @jbombien what would you like to do with your changes? |
get_app_access_token rewritten with requests get_access_token_from_code rewritten with requests request rewritten with requests all graphapi calls converted to use requests deprecating old commands
Hey, |
Any word on this @martey ? |
Bump? @martey |
I have not merged this request because we do not have a test suite to automate testing, and I do not currently have the time to manually test these changes. The quickest way to get this merged would be for someone to submit pull requests containing tests. I am on my honeymoon right now (with intermittent Internet access), so it is difficult for me to do this myself until next month at the earliest. |
My last PR [#68] became garbled because of some github project owner changes. Opening this one.