Replace urllib with Python Requests #68
Conversation
get_app_access_token rewritten with requests get_access_token_from_code rewritten with requests request rewritten with requests all graphapi calls converted to use requests deprecating old commands
|
Some of these commits (mvid@a5521cc for example) are non-starters, but I will review the others when I have time. |
|
Understandable. I would prefer to merge this mainline than to fork it. I will roll those all back. |
|
Why were |
|
They were not removed, but replaced with Graph object implementations. The functions still exist, but simply call the a Graph instance function. They are also marked deprecated. The functions were documented as being external to the Graph object because they returned query-args instead of json. Now that the Graph objects can handle query-arg responses, they don't need to be separate. |
|
I think it makes sense to keep them undeprecated because of the way the GraphAPI object is currently initialized. Which these changes, one must create a GraphAPI object and then run either I could see newcomers being confused about the fact that the returned access token is not automatically applied to the GraphAPI object. If we change it, I could see people upgrading being burned by this new behavior. I think it might make sense to change the |
|
Makes sense. I will remove the deprecation warnings. |
|
Marty - having trouble with google appengine. Are your changes supposed to work on GAE? |
|
@skarra, are you having trouble with the changes in this pull request? If not, you should either use the Google group (if you need technical support) or file a new issue (if you think you have found a bug). |
|
@skarra yes they are supposed to work. Feel free to email or twitter message me your issues, if they are related to this pull request. |
|
I have addressed the deprecation issue in my PR. Apologies for the amount of time that has passed. Closing this PR, as the new one is the active one. |
looking for some feedback, seeing if it is possible to get this merged mainline?