Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement getNodeId #1225

Merged
merged 2 commits into from
Mar 15, 2019
Merged

implement getNodeId #1225

merged 2 commits into from
Mar 15, 2019

Conversation

xaviergonz
Copy link
Contributor

Fixes #1168

Also made some refactoring to avoid repetitive assertions on arguments

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 91.788% when pulling 5085695 on getNodeId into 5d83a8c on master.

@xaviergonz xaviergonz merged commit a81647e into master Mar 15, 2019
@faassen faassen mentioned this pull request Mar 19, 2019
Open
@xaviergonz xaviergonz deleted the getNodeId branch May 4, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xaviergonz @coveralls