Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Instance import in docs #1834

Merged
merged 2 commits into from Dec 4, 2021
Merged

Include Instance import in docs #1834

merged 2 commits into from Dec 4, 2021

Conversation

hgulersen
Copy link
Contributor

@hgulersen hgulersen commented Nov 20, 2021 •
edited

It is unclear where Instance is coming from - I've thought it was a TS built-in for a while until I realized it somewhere else

@hgulersen
Include imports in docs
d7a0acb 
It is unclear where `Instance` is coming from - I've thought it was a TS built-in for a while until I realized it somewhere lese
elektronik2k5
elektronik2k5 suggested changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@elektronik2k5 elektronik2k5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the import should be there. In which case, for the sake of completeness and consistency, all imports should appear in the example.

docs/tips/typescript.md Outdated Show resolved Hide resolved
@jamonholmgren @elektronik2k5
Update docs/tips/typescript.md
b5f4ae1 
Co-authored-by: Nick Ribal <elektronik2k5@users.noreply.github.com>
@jamonholmgren jamonholmgren merged commit 1c752e0 into mobxjs:master Dec 4, 2021
@jamonholmgren
Copy link
Collaborator

Released in https://github.com/mobxjs/mobx-state-tree/releases/tag/v5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elektronik2k5 elektronik2k5 elektronik2k5 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hgulersen @jamonholmgren @elektronik2k5