Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: advanced createFactory definition #38

Merged
merged 2 commits into from
Feb 15, 2017
Merged

feat: advanced createFactory definition #38

merged 2 commits into from
Feb 15, 2017

Conversation

mattiamanzati
Copy link
Contributor

Downsides: Snapshot aren't typed and using non-action functions break the typings. Still a 80% cases coverage.

@mweststrate
Copy link
Member

Requires release of: mobxjs/mobx#796

@mweststrate
Copy link
Member

@mattiamanzati bumped mobx to 3.1, build should now succeed, feel free to merge if nothing else was left here

@mweststrate
Copy link
Member

And now pushed on the correct branch :/

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.761% when pulling 3d50c2d on feature/create-factory-typings into 5e2d5d0 on feature/constant-and-maybe-types.

@mattiamanzati mattiamanzati merged commit d9e7b58 into feature/constant-and-maybe-types Feb 15, 2017
@mattiamanzati mattiamanzati deleted the feature/create-factory-typings branch February 15, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattiamanzati @mweststrate @coveralls