Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added IAction to action function return type #796

Merged
merged 2 commits into from
Jan 26, 2017
Merged

feat: added IAction to action function return type #796

merged 2 commits into from
Jan 26, 2017

Conversation

mattiamanzati
Copy link
Contributor

As discussed with @mweststrate, added IAction to the return type of an action() call.

PR checklist:

  • Implementation
  • Added tests
  • Verified that there is no significant performance drop (npm run perf)
  • Updated (either in the description of this PR as markdown, or as seperate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added type annotations (if you are unfamiliar with typescript, untyped, :any based PRs are welcome as well

@mweststrate mweststrate mentioned this pull request Jan 24, 2017
Merged
@mattiamanzati
Copy link
Contributor Author

@mweststrate Is it normal to travis to fail? Npm run test seems fine.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.19% when pulling bb4625d on feature/action-interface into 185cc13 on master.

@mweststrate mweststrate merged commit 67f8255 into master Jan 26, 2017
@mweststrate mweststrate deleted the feature/action-interface branch March 30, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattiamanzati @coveralls @mweststrate