Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update analyzer version to >=4.4.0 <6.0.0 #877

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Oct 17, 2022

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

Fixes #875
Fixes #850


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melo run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for mobx canceled.

Name Link
🔨 Latest commit a86b769
🔍 Latest deploy log https://app.netlify.com/sites/mobx/deploys/63711763e6a33500081299c8

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #877 (a86b769) into master (0391ef0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          55       55           
  Lines        1923     1923           
=======================================
  Hits         1903     1903           
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.53% <ø> (ø)
mobx_codegen 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mobx_codegen/lib/src/type_names.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0391ef0...a86b769. Read the comment docs.

@tim-eucalyptus
Copy link

I'm hoping this gets merged ASAP and we get a new release! Thanks!

@fzyzcjy
Copy link
Collaborator

fzyzcjy commented Oct 18, 2022

LGTM but ci seems to fail? please fix it before merging if possible :)

@amondnet
Copy link
Collaborator Author

@fzyzcjy Maybe mocktail has a problem with dart beta.

@amondnet
Copy link
Collaborator Author

felangel/mocktail#159

@tim-eucalyptus
Copy link

Fails on 3 tests on beta.

@amondnet
Copy link
Collaborator Author

@amondnet
Copy link
Collaborator Author

#879

@tim-eucalyptus tim-eucalyptus mentioned this pull request Oct 27, 2022
7 tasks
@pavanpodila
Copy link
Member

There are some failing tests in mobx. Can you see @amondnet ?

@HudsonAfonso
Copy link

news?

@tim-eucalyptus
Copy link

All checks have now passed. Ready to merge! :)

@pavanpodila pavanpodila merged commit b3e5648 into mobxjs:master Nov 14, 2022
tlvenn pushed a commit to magelo-labs/mobx.dart_old that referenced this pull request Dec 31, 2022
tlvenn pushed a commit to magelo-labs/mobx.dart_old that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dart_code_metrics >=4.20.0 is incompatible with mobx_codegen 2.0.7+3 analyzer > 4.3.0 has deprecated method
5 participants