Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix tests in dart 2.19 #879

Merged
merged 3 commits into from
Nov 13, 2022
Merged

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Oct 24, 2022

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

Dart 2.19 doesn't delegate inaccessible private names to noSuchMethod.

https://github.com/dart-lang/sdk/blob/main/CHANGELOG.md#2190
dart-lang/language#2020
dart-lang/sdk#49687
dart-lang/site-www#4263

https://github.com/mobxjs/mobx.dart/blob/master/mobx/test/observable_test.dart

The test fails on dart 2.19.

https://github.com/mobxjs/mobx.dart/actions/runs/3262020308/jobs/5359681093


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melo run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for mobx canceled.

Name Link
🔨 Latest commit c6e238c
🔍 Latest deploy log https://app.netlify.com/sites/mobx/deploys/636b234a6afa160009d17d24

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #879 (5f7d132) into master (021f4a0) will decrease coverage by 1.04%.
The diff coverage is 100.00%.

❗ Current head 5f7d132 differs from pull request most recent head c6e238c. Consider uploading reports for the commit c6e238c to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #879      +/-   ##
===========================================
- Coverage   100.00%   98.95%   -1.05%     
===========================================
  Files            5       55      +50     
  Lines           97     1923    +1826     
===========================================
+ Hits            97     1903    +1806     
- Misses           0       20      +20     
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.53% <100.00%> (?)
mobx_codegen 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mobx/lib/src/core.dart 100.00% <ø> (ø)
mobx/lib/src/core/atom.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/computed.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/context.dart 97.16% <100.00%> (ø)
mobx/lib/src/core/reaction.dart 98.52% <100.00%> (ø)
mobx/lib/src/core/action.dart 100.00% <0.00%> (ø)
mobx/lib/src/utils.dart 100.00% <0.00%> (ø)
mobx_codegen/lib/src/type_names.dart 100.00% <0.00%> (ø)
mobx_codegen/lib/src/template/store.dart 100.00% <0.00%> (ø)
...src/api/extensions/primitive_types_extensions.dart 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021f4a0...c6e238c. Read the comment docs.

Copy link
Collaborator

@fzyzcjy fzyzcjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the codecov

@tim-eucalyptus
Copy link

Would be great to see this merged as it's holding up: #877. Thanks!

mobx/CHANGELOG.md Outdated Show resolved Hide resolved
mobx/lib/src/core/reaction.dart Show resolved Hide resolved
@tim-eucalyptus
Copy link

Hey can someone please merge this already? It's really holding up our project as we cannot update to freezed 2.2.1 with a critical bug fix.

@tim-eucalyptus
Copy link

Any update on this??

@HudsonAfonso
Copy link

news?

@pavanpodila pavanpodila merged commit 0391ef0 into mobxjs:master Nov 13, 2022
@amondnet amondnet deleted the fix-test-2.19 branch December 19, 2022 16:26
tlvenn pushed a commit to magelo-labs/mobx.dart_old that referenced this pull request Dec 31, 2022
* test: fix tests in dart 2.19

* test: fix tests in dart 2.19

* test: fix tests in dart 2.19
tlvenn pushed a commit to magelo-labs/mobx.dart_old that referenced this pull request Dec 31, 2022
* test: fix tests in dart 2.19

* test: fix tests in dart 2.19

* test: fix tests in dart 2.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants