Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache getKeys() of ObservableObjectAdministration #2410

Merged
merged 2 commits into from
Aug 5, 2020
Merged

cache getKeys() of ObservableObjectAdministration #2410

merged 2 commits into from
Aug 5, 2020

Conversation

MoonBall
Copy link
Contributor

@MoonBall MoonBall commented Jul 26, 2020 •
edited by gitpod-io bot
Loading

Code change checklist

  • Added/updated unit tests
  • Updated changelog
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (npm run perf)

I made the PR to cache getKeys() of ObservableObjectAdministration.
When I run yarn test, the program hit the cache 91 times.

@gitpod-io
Copy link

gitpod-io bot commented Jul 26, 2020 •
edited
Loading

mweststrate
mweststrate approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge before v6

@mweststrate mweststrate merged commit 7b77af2 into mobxjs:mobx6 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweststrate mweststrate mweststrate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoonBall @mweststrate