Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate global property check #2985

Merged
merged 3 commits into from
Jun 20, 2021
Merged

Remove duplicate global property check #2985

merged 3 commits into from
Jun 20, 2021

Conversation

fecqs
Copy link
Contributor

@fecqs fecqs commented Jun 13, 2021

I find that "Symbol" is duplicated and should be removed

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (npm run perf)

I find that "Symbol" is duplicated and should be removed
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2021

🦋 Changeset detected

Latest commit: 052a3d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@iChenLei iChenLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urugator urugator merged commit c6dc925 into mobxjs:main Jun 20, 2021
@github-actions github-actions bot mentioned this pull request Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants