React18 support #3387
Merged
React18 support #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a6066dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kubk
reviewed
May 3, 2022
packages/mobx-react-lite/__tests__/strictAndConcurrentMode.test.tsx
Outdated
Show resolved
Hide resolved
|
what more needs to be done to approve this? |
|
Writing a good changelog what is and is not addressed. Hope to get to that tomorrow😅 |
kubk
approved these changes
May 5, 2022
vkrol
reviewed
May 5, 2022
Co-authored-by: Veniamin Krol <153412+vkrol@users.noreply.github.com>
Merged
|
@mweststrate sorry, what does |
|
In combination with. Sorry should have spelled that out.
…On Sat, 7 May 2022, 06:39 An Phi, ***@***.***> wrote:
@mweststrate <https://github.com/mweststrate> sorry, what does icmw mean?
—
Reply to this email directly, view it on GitHub
<#3387 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN4NBH7GD2D37XNT3U6VCDVIX6YZANCNFSM5U6ESFMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull adds experimental / poor man's support for React 18. Fixes #3363, #2526. Supersedes #3005
useMutableSourcewill trigger warnings in React 18, which is correct and those shouldn't be used anymore.actis used in unit tests around every programmatic mutation. Without it, changes won't propagate!useSyncExternalStoreand capturing the current values with together with the dependency tree of every component instance. However that isn't included in this pull request 1) it would be a breaking change, whereas the current change is still compatible with React 16 and 17. 2) I want to collect use cases where the tearing leads to problems first to build a better problem understanding. If you run into the problem, please submit an issue describing your scenario, and a PR with a unit tests demonstrating the problem in simplified form. For further discussion see Support concurrent features React / React 18 #2526, [WIP] Support React 18 #3005