Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3395: observer not working with <React.StrictMode> #3434

Merged
merged 6 commits into from
Jun 27, 2022

Conversation

urugator
Copy link
Collaborator

Fixes #3395

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2022

🦋 Changeset detected

Latest commit: 8bf5afa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@urugator
Copy link
Collaborator Author

urugator commented Jun 26, 2022

I wonder whether instead of patching componentDidMount, we could just call forceUpdate in componentWillUnmount, so the component is immediately dirty (and therefore forced to re-render) in case it re-mounts. The doc states:

You should not call setState() in componentWillUnmount() because the component will never be re-rendered. Once a component instance is unmounted, it will never be mounted again.

But that's obviously no longer true...

@urugator urugator merged commit bbcb12d into mobxjs:main Jun 27, 2022
@github-actions github-actions bot mentioned this pull request Jun 27, 2022
@mweststrate
Copy link
Member

Thanks for investigating @urugator! Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 18: observer not working with <React.StrictMode>
2 participants