Skip to content

Commit

Permalink
Merge pull request #1567 from everpeace/fix-authority-header
Browse files Browse the repository at this point in the history
Setting `Host` part  of address url to `:authority` pseudo header
  • Loading branch information
tonistiigi committed Aug 6, 2020
2 parents 545532a + 804aa5d commit 279d686
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"crypto/x509"
"io/ioutil"
"net"
"net/url"

grpc_middleware "github.com/grpc-ecosystem/go-grpc-middleware"
"github.com/grpc-ecosystem/grpc-opentracing/go/otgrpc"
Expand Down Expand Up @@ -71,6 +72,15 @@ func New(ctx context.Context, address string, opts ...ClientOpt) (*Client, error
address = appdefaults.Address
}

// grpc-go uses a slightly different naming scheme: https://github.com/grpc/grpc/blob/master/doc/naming.md
// This will end up setting rfc non-complient :authority header to address string (e.g. tcp://127.0.0.1:1234).
// So, here sets right authority header via WithAuthority DialOption.
addressURL, err := url.Parse(address)
if err != nil {
return nil, err
}
gopts = append(gopts, grpc.WithAuthority(addressURL.Host))

unary = append(unary, grpcerrors.UnaryClientInterceptor)
stream = append(stream, grpcerrors.StreamClientInterceptor)

Expand Down

0 comments on commit 279d686

Please sign in to comment.