Setting Host
part of address url to :authority
pseudo header
#1567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1566
What I've changed
This PR sets custom
:authority
pseudo header withHost
part of address url viagrpc.WithAuthority
dial option.This is because:
I think current
--addr
option usesnet.URL
even though custom connection helpers likekube-pod://, dockercontainer://
. So, I think that takingurl.Host
part wouldn't cause a serial problem.