local: handle canceled uploads #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
approved these changes
May 28, 2019
|
Ping @AkihiroSuda feel free to review post merge, you may catch something I haven't seen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the transfer of local sources is canceled or errors, checksum calculation is left in undefined state. After another build completes the transfer, the checksums may not correspond to the actual data on disk. With this quick patch, we always clean up the ref on error so next build starts from empty state. Later this could be optimized, for example do a full scan instead.
The reason this didn't show up very often is because of the lru cache for cache context. If cache was looked up from lru it still had the previous incomplete state that matched the disk state in 99% of cases(depending on where exactly the error happened).
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com