pull: add cache for gcr bug #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
reviewed
May 31, 2019
| ref = r.repo(ref) + "-" + session.FromContext(ctx) | ||
|
|
||
| cr, ok := r.m[ref] | ||
| cr.timeout = time.Now().Add(time.Minute) |
There was a problem hiding this comment.
Same as in moby. This should be enough to avoid the second request in most cases. Ideally, this could be connected to the /session dropping.
AkihiroSuda
approved these changes
Jun 9, 2019
tiborvass
reviewed
Jun 17, 2019
| var cache *resolverCache | ||
|
|
||
| func init() { | ||
| cache = newResolverCache() |
There was a problem hiding this comment.
nit, but no need for init(), can be var cache = newResolverCache()
tiborvass
approved these changes
Jun 17, 2019
|
Is this in the vendored code in Moby? If so we might want to backport to the 18.09 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #720
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com