Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build errors and remove useless grpc prefix #2215

Merged
merged 2 commits into from Jul 1, 2021

Conversation

tonistiigi
Copy link
Member

Before:

------
 > [st3 2/2] RUN sleep 1 && echo foobar && exit 1:
------
Dockerfile:9
--------------------
   7 |     
   8 |     from alpine as st3
   9 | >>> run sleep 1 && echo foobar && exit 1
  10 |     
  11 |     from scratch
--------------------
error: failed to solve: rpc error: code = Unknown desc = executor failed running [/bin/sh -c sleep 1 && echo foobar && exit 1]: exit code: 1

After:

------
 > [st3 2/2] RUN sleep 1 && echo foobar && exit 1:
#10 2.308 foobar
------
Dockerfile:9
--------------------
   7 |     
   8 |     from alpine as st3
   9 | >>> run sleep 1 && echo foobar && exit 1
  10 |     
  11 |     from scratch
--------------------
error: failed to solve: process "/bin/sh -c sleep 1 && echo foobar && exit 1" did not complete successfully: exit code: 1

Expecting tests that check error strings to fail.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi marked this pull request as ready for review July 1, 2021 05:17
@AkihiroSuda AkihiroSuda merged commit 8d70a9e into moby:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants