Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration: missing feature compat checks #3715

Merged
merged 3 commits into from
Mar 15, 2023
Merged

integration: missing feature compat checks #3715

merged 3 commits into from
Mar 15, 2023

Conversation

crazy-max
Copy link
Member

follow-up #3713 (comment)

@crazy-max crazy-max mentioned this pull request Mar 14, 2023
Merged
tonistiigi
tonistiigi reviewed Mar 14, 2023
View reviewed changes
client/client_test.go Outdated Show resolved Hide resolved
tonistiigi
tonistiigi reviewed Mar 14, 2023
View reviewed changes
client/client_test.go Outdated Show resolved Hide resolved
@crazy-max
integration: missing feature compat check for cache
7f6cae2 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
integration: split feature compat check for subtests
365598b 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi
Copy link
Member

Based on moby/moby#45153 (comment)

=== CONT  TestClientGatewayIntegration/TestClientGatewayNilResult/worker=dockerd
    build_test.go:2010: 
        	Error Trace:	/src/client/build_test.go:2010
        	            				/src/client/client.go:214
        	            				/src/client/build.go:59
        	            				/src/client/solve.go:283
        	            				/src/client/errgroup.go:75
        	            				/src/client/asm_amd64.s:1594
        	Error:      	Received unexpected error:
        	            	requested experimental feature diffop  has been disabled on the build server: only enabled with containerd image store backend
    ```

Also needs a mergeop feature check.

@crazy-max
integration: missing mergeDiff compat check
f5aa841 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title integration: missing feature compat check for cache integration: missing feature compat checks Mar 15, 2023
@crazy-max
Copy link
Member Author

Yes indeed: https://github.com/moby/moby/actions/runs/4425013900/jobs/7759638671#step:10:1874

@tonistiigi tonistiigi merged commit 3318657 into moby:master Mar 15, 2023
@crazy-max crazy-max deleted the missing-cache-features branch March 15, 2023 13:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
area/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crazy-max @tonistiigi