exporter: unlazy references in parallel #3984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From slack:
We can unlazy all the references in parallel, since these perform network operations, we should attempt to pull them all together, instead of one-after-each-other.
We can also use theEachRef
helper to simplify the iteration over all the references - I think this now would include the attestation references? I don't think this affects anything since attestation references weren't lazily computed, and it just makes sure that they are included in the multi-provider.