Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter: unlazy references in parallel #3984

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented Jun 30, 2023

From slack:

jed: for the unlazying stuff we do in the exporter - should we perform this in parallel over all the refs? I notice when it's pulling images, we actually pull two different architectures in sequence, instead of in parallel.
It's a pretty quick fix with an errgroup, but maybe it's intentional as is?

tonistiigi: No reason this could be intentional

We can unlazy all the references in parallel, since these perform network operations, we should attempt to pull them all together, instead of one-after-each-other.

We can also use the EachRef helper to simplify the iteration over all the references - I think this now would include the attestation references? I don't think this affects anything since attestation references weren't lazily computed, and it just makes sure that they are included in the multi-provider.

@jedevc jedevc requested a review from tonistiigi June 30, 2023 15:51
@jedevc jedevc changed the title exporter: use eachref helper to unlazy references exporter: unlazy references in parallel Jun 30, 2023
@jedevc jedevc marked this pull request as draft June 30, 2023 16:26
@jedevc

This comment was marked as resolved.

Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc marked this pull request as ready for review July 3, 2023 10:43
@tonistiigi tonistiigi merged commit 9bc05a1 into moby:master Jul 6, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants