-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't support cgroupns on cgroups v1 #4308
Conversation
Fixes moby#4108 Signed-off-by: Mark Yen <mark.yen@suse.com>
executor/oci/spec_linux.go
Outdated
@@ -150,9 +150,13 @@ func getTracingSocket() string { | |||
|
|||
func cgroupNamespaceSupported() bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func cgroupNamespaceSupported() bool { | |
func cgroupV2NamespaceSupported() bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add comment lines to explain the background for this
This responds to review feedback from moby#4308 (review) Signed-off-by: Mark Yen <mark.yen@suse.com>
func cgroupV2NamespaceSupported() bool { | ||
// Check if cgroups v2 namespaces are supported. Trying to do cgroup | ||
// namespaces with cgroups v1 results in EINVAL when we encounter a | ||
// non-standard hierarchy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a link to the issue ticket
This responds to review feedback from moby#4308 (review) Signed-off-by: Mark Yen <mark.yen@suse.com>
24daf29
to
f9ccb09
Compare
I think we can merge this but we would still like to see the original issue to be analyzed properly |
This was added in #4003 and released in v0.12 that should be the regression point. |
This responds to review feedback from moby#4308 (review) Signed-off-by: Mark Yen <mark.yen@suse.com> (cherry picked from commit f9ccb09) Signed-off-by: Justin Chadwell <me@jedevc.com>
This responds to review feedback from moby#4308 (review) Signed-off-by: Mark Yen <mark.yen@suse.com>
Possibly fixes #4108.
Note that I have no idea what I'm doing; I'm basing the new stat call on what the tests in #4003 are doing (on the assumption that if it is not compatible with the test, it was probably what broke my use cases too). Any suggestions on what to do instead (or even just PRs that replace this one) very welcome.