Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: default linter to run on all stages by default #5000

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

tonistiigi
Copy link
Member

fix #4988

When linter subrequest is sent without target, the expected behavior is to check full Dockerfile, not only the last target. During build the warnings are unchanged.

Some issues with this:

  • Some rules are not scoped by specific stages atm. Some like casing may be more expected than others like the ENV key value syntax.
  • If the last stage is unnamed there isn't currently a way to check only that one with subrequest.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi marked this pull request as ready for review June 6, 2024 16:49
@tonistiigi tonistiigi added this to the v0.14.0 milestone Jun 6, 2024
…een progress and unmarshal test types

Signed-off-by: Talon Bowler <talon.bowler@docker.com>
(cherry picked from commit 6690e9a)
@thompson-shaun thompson-shaun self-assigned this Jun 6, 2024
@tonistiigi tonistiigi merged commit e758c78 into moby:master Jun 6, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to all targets when running build linting checks
5 participants