dockerfile: only report legacy key/value format when stage is reachable #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
approved these changes
Jun 6, 2024
daghack
approved these changes
Jun 6, 2024
tonistiigi
requested changes
Jun 6, 2024
| ENV key value | ||
| LABEL key value | ||
|
|
||
| FROM a AS c | ||
| `) | ||
| checkLinterWarnings(t, sb, &lintTestParams{Dockerfile: dockerfile}) |
There was a problem hiding this comment.
I think this test will not pass after rebase to #5000 and should needs to be rewritten like the test in that PR
There was a problem hiding this comment.
Rebased and updated.
This modifies the linter to only report the legacy key/value format if the stage is reachable to be more compatible with the other lints that operate this way. Instead of reporting the warning in the parser, it records whether a delimiter is present in the KeyValuePair and this gets checked when the dispatch happens. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
legacy-env-lint-dispatch-only
branch
from
90f5a74
to
c4c2dbf
Compare
tonistiigi
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the linter to only report the legacy key/value format if the stage is reachable to be more compatible with the other lints that operate this way.
Instead of reporting the warning in the parser, it records whether a delimiter is present in the KeyValuePair and this gets checked when the dispatch happens.