source: Have ResolveMode implement fmt.Stringer interface #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Out of the two ResolveMode types in buildkit, only the lower-level one in client/llb had a String() method. This patch makes the ResolveMode type from the source package also have a String() method. Signed-off-by: Tibor Vass <tibor@docker.com>
|
@AkihiroSuda @ijc I'm not 100% sure if I'm doing what's expected or if there's refactoring to be done. My understanding is that these types although they seem duplicates, they are intended to be used at two different level of abstractions. Let me know if I misunderstood, in which case I could refactor, I just don't want to clutter the dependency graph more. |
ijc
approved these changes
Aug 17, 2018
|
I'm not sure about the duplication either, but adding this for now seems harmless. I'm also not entirely clear why these are |
AkihiroSuda
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of the two ResolveMode types in buildkit, only the lower-level one in client/llb
had a String() method. This patch makes the ResolveMode type from the source package
also have a String() method.
Signed-off-by: Tibor Vass tibor@docker.com