Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack: fix tagging latest images on release #876

Merged
merged 1 commit into from
Mar 15, 2019
Merged

hack: fix tagging latest images on release #876

merged 1 commit into from
Mar 15, 2019

Conversation

tonistiigi
Copy link
Member

typo from https://github.com/moby/buildkit/pull/847/files#diff-ed0ae453c7dab73db35f74c6092f6e88R74

I manually retagged the v0.4.0 images so no need to run it again.

@AkihiroSuda

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi
hack: fix tagging latest images on release
a469f28 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
thaJeztah
thaJeztah approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Flaky test?

    --- FAIL: TestIntegration/TestCacheImportExport/worker=containerd/frontend=client (13.24s)
        require.go:1159: 
            	Error Trace:	dockerfile_test.go:3064
            	            				dockerfile_test.go:2527
            	            				run.go:160
            	Error:      	Should be true
            	Test:       	TestIntegration/TestCacheImportExport/worker=containerd/frontend=client

@tonistiigi
Copy link
Member Author

@thaJeztah yes, #399 (No actual issue afaik, just gc invoking is unpredictable)

@thaJeztah thaJeztah merged commit a18c3d0 into moby:master Mar 15, 2019
@AkihiroSuda
Copy link
Member

Thanks and sorry for breaking this 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonistiigi @thaJeztah @AkihiroSuda