-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] expose more functions on Target.v
#430
Conversation
@@ -87,6 +87,10 @@ let path = function | |||
|
|||
type v = [ `PR of PR.t | `Ref of Ref.t ] | |||
|
|||
let pp_v f = function | |||
| `PR pr -> Fmt.pf f "pr/%a" PR.pp pr | |||
| `Ref x -> Fmt.pf f "refs/%a" Ref.pp x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems strange that one case is plural and the other isn't.
Looks like we use pr
and ref
in URLs, but prs/heads/tags
when parsing. Git uses .git/refs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes not sure where this is used. I've tried to not use s
in the datakit/github bridge, but indeed Git is putting s
everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only using this pp_v function for branch name calculation, so the values don't seem significant (but should be consistent). I'll modify it to be plural to match Git then.
These are convenience functions that match the equivalents for the unresolved `Target.t`, used in mirage-ci Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
the CI seems to have failed for reasons other than this patch. |
minor nitpick: can you change back to use singular for |
What causes this?
|
@samoht I think |
But these are alpine images. |
@avsm ha yes you are right. I'm fine with the |
I've been migrating the Alpine images to use a builtin solver since Alpine 3.5 -- there was a brief period where they were using the cloud solver too (and pre Alpine 3.5 images still use the cloud solver since there is no backport). More at ocaml/opam#2809 (comment) |
These are convenience functions that match the equivalents for
the unresolved
Target.t
, used in mirage-ci