Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refer to mirage module types modules by new name #433

Closed
wants to merge 1 commit into from

Conversation

yomimono
Copy link
Contributor

@yomimono yomimono commented Jan 7, 2017

V1 is now Mirage_types, and V1_LWT is now Mirage_types_lwt, as of MirageOS version 3.0.0.

@talex5
Copy link
Contributor

talex5 commented Jan 7, 2017

CI failed with:

[WARNING] External solver failed with inconsistent return value. Request saved
          to "/home/opam/.opam/log/solver-error-19-1.cudf"
[ERROR] External solver failure, please fix your installation and check
        /home/opam/.opam/config and variable $OPAMEXTERNALSOLVER.
        You may also retry with option --use-internal-solver

moby/datakit.logs@46c2ea4#diff-dc1d71bbb5c4d2a5e936db79ef10c19fR121

@djs55
Copy link
Collaborator

djs55 commented Jan 7, 2017

FWIW I think I saw the same error earlier today when building an ocaml package locally in an alpine container.

Signed-off-by: Mindy Preston <mindy.preston@docker.com>
@talex5
Copy link
Contributor

talex5 commented Jan 9, 2017

I guess this needs to wait for Mirage 3 to be released.

@avsm
Copy link
Collaborator

avsm commented Jan 9, 2017

CentOS and Fedora are the only containers that use the Docker Cloud-hosted solver.ocaml.io, so you will see that error if the infra is down. The builds can be restarted.

@yomimono
Copy link
Contributor Author

@talex5 if it bugs you to leave this PR open, I'm happy to resubmit it later or point it at a mirage-dev branch.

@talex5
Copy link
Contributor

talex5 commented Jan 13, 2017

I think it's fine to keep it open. I've tagged it as tracking.

avsm added a commit to avsm/mirage-dev that referenced this pull request Jan 18, 2017
@samoht
Copy link
Member

samoht commented Apr 26, 2017

Superseded by #529 and #531 which have been merged.

@samoht samoht closed this Apr 26, 2017
@yomimono yomimono deleted the rename-v1 branch April 26, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants