ci: include test name in links from GitHub #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoht
reviewed
Mar 29, 2017
datakit-ci.opam
Outdated
| @@ -9,12 +9,12 @@ dev-repo: "https://github.com/docker/datakit.git" | |||
| doc: "https://docker.github.io/datakit/" | |||
|
|
|||
| build: [ | |||
| "ocaml" "pkg/pkg.ml" "build" "--pinned" "%{pinned}%" "--tests" "false" "-n" name | |||
| "ocaml" "pkg/pkg.ml" "build" "--dev-pkg" "%{pinned}%" "--tests" "false" "-n" name | |||
There was a problem hiding this comment.
Not needed, but https://github.com/dbuenzli/topkg/blob/master/CHANGES.md#v090-la-forclaz-vs says Deprecate --pinned in favor of --dev-pkg in the build command.
|
CI failed because: This usually means no aspcud. But I think the newer Docker image with aspcud also has a newer opam-dev that can't install test dependencies. |
talex5
force-pushed
the
test-links
branch
2 times, most recently
from
283d825
to
6ba2cbf
Compare
added 2 commits
March 29, 2017 15:31
Without this, opam often makes poor version choices. This was probably the underlying cause of moby#507. Signed-off-by: Thomas Leonard <thomas.leonard@docker.com>
Highlight the test when showing the target page. Signed-off-by: Thomas Leonard <thomas.leonard@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the test name to the details URL so that we can highlight the correct test automatically.
Also, ensure aspcud is used during the build to get better dependency resolution.