Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more than 16 vCPUs #96

Closed
dsheets opened this issue Jan 16, 2017 · 3 comments · Fixed by #97
Closed

Allow more than 16 vCPUs #96

dsheets opened this issue Jan 16, 2017 · 3 comments · Fixed by #97
Labels
enhancement

Comments

@dsheets
Copy link
Collaborator

dsheets commented Jan 16, 2017

Currently https://github.com/docker/hyperkit/blob/master/src/include/xhyve/vmm/vmm_common.h#L33 restricts the maximum number of vCPUs to 16. For compute-heavy workloads, this arbitrary restriction may be undesirable (see docker/for-mac#1144). This number is mainly used to size static arrays but, as @ijc25 notes, there may be work checking that ACPI tables are set up correctly to offer enough cores correctly.
@rn
Copy link
Member

rn commented Jan 16, 2017

acpitbl.c takes a number of CPU argument and scales the various ACPI tables and their content by it. So it may work...

@grehan-freebsd
Copy link

Just be aware of table sizing/overflow (http://docs.FreeBSD.org/cgi/mid.cgi?2ebbc1f9-4b1e-74f2-60fc-c0976b7924a1)

@rn
Copy link
Member

rn commented Jan 17, 2017

@grehan-freebsd thanks for the heads up!

@rn rn mentioned this issue Jan 17, 2017
Merged
rn added a commit to rn/hyperkit that referenced this issue Jan 20, 2017
@rn
Increase the maximum number of vCPUs to 64
7bedf92 
Increase the MADT size accordingly. Add a compile time
check to make sure the MADT doesn't overflow into the FADT.

resolves moby#96

Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
@rn rn closed this as completed in #97 Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase the maximum number of vCPUs to 64 rn/hyperkit
3 participants
@dsheets @rn @grehan-freebsd