Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] restructure the layout of the source code #65

Merged
merged 7 commits into from
Oct 17, 2016
Merged

Conversation

rn
Copy link
Member

@rn rn commented Oct 11, 2016

  • All source code moved to ./src (including include files)
  • Move bulk of the implementation into a ./lib directory
  • Move all test files under ./test
  • Remove some un-used files
  • Other minor tweaks like

/ping @ijc @avsm

@ijc
Copy link
Collaborator

ijc commented Oct 12, 2016

I don't really expect this sort of thing to be reviewable but I had a poke through:

git fetch origin
git fetch origin pull/65/head
git diff -C -M origin/master FETCH_HEAD
git diff --stat -C -M origin/master FETCH_HEAD
gitk origin/master..FETCH_HEAD

Looks like src: move the bulk of the source code into ./src/lib also stripped some trailing whitespace, hopefully no actual semantic changes mixed in, but I wasn't about to actually read the diff to acpitbl.c ;-). Likewise src: move include files into ./src.

FWIW I tend to use build/opam as my local private opam, but I gather opam2 will pickup .opam automatically, so that's clearly a better choice in the long run.

Is dsdt.asl (secretly, and manually) the source to a bunch of the hard coded tables in acpitbl.c? I'm not really sure.

Anyway, nothing blocking here, so LGTM

@rn
Copy link
Member Author

rn commented Oct 12, 2016

ah, my git config has:

[apply]
    whitespace = fix

and must have fixed them up. I just reviewed the changes and they all look fine.

As for dsdt.asl I couldn't find any reference in the source. acpitbl.c was introduced with this patch. The commit suggests that with bhyve the DSDT is generated on the fly on VM start (using iasl) and the patch introduced minimal mostly hard-coded tables. So we should be fine.

rn and others added 7 commits October 17, 2016 10:39
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Also adjust the make variables and their names

Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
@rn
Copy link
Member Author

rn commented Oct 17, 2016

rebased onto #66

@ijc ijc merged commit 6165f6a into moby:master Oct 17, 2016
@rn rn deleted the reorg branch October 17, 2016 16:57
rn pushed a commit to rn/hyperkit that referenced this pull request Oct 24, 2016
[RFC] restructure the layout of the source code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants