kexec: Rename "memory" to "lowmem". #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, makes the code easier to read |
Various bits of code (e.g. kernel and initrd loading) rely on memory.base and memory.size referring to lowmem only, with highmem being handled separately, in order to avoid locating things into the MMIO region between the two. Rename the variable to make this more obvious and to forestall any ideas about "fixing" memory.size. Signed-off-by: Ian Campbell <ian.campbell@docker.com>
|
Rebased onto #65 |
zchee
added a commit
to zchee/xhyve
that referenced
this pull request
Oct 21, 2016
backport to moby/hyperkit#68 Original commit messages Various bits of code (e.g. kernel and initrd loading) rely on memory.base and memory.size referring to lowmem only, with highmem being handled separately, in order to avoid locating things into the MMIO region between the two. Rename the variable to make this more obvious and to forestall any ideas about "fixing" memory.size. Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
rn
added a commit
to rn/hyperkit
that referenced
this pull request
Oct 24, 2016
kexec: Rename "memory" to "lowmem".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various bits of code (e.g. kernel and initrd loading) rely on memory.base and
memory.size referring to lowmem only, with highmem being handled separately, in
order to avoid locating things into the MMIO region between the two.
Rename the variable to make this more obvious and to forestall any ideas about
"fixing" memory.size.
Signed-off-by: Ian Campbell ian.campbell@docker.com
/cc @zchee I think this would have saved us a few RTTs on #66!
/cc @rneugeba I'll hold off on this until after #65 and rebase accordingly once you have merged.