Use sysfs to set hairpin mode #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjana
force-pushed
the
bugs
branch
13 times, most recently
from
66889d3
to
a37f73d
Compare
| @@ -772,6 +775,37 @@ func addToBridge(ifaceName, bridgeName string) error { | |||
| return ioctlAddToBridge(iface, master) | |||
| } | |||
|
|
|||
| func setHairpinMode(link netlink.Link, enable bool) error { | |||
| err := netlink.LinkSetHairpin(link, true) | |||
There was a problem hiding this comment.
shouldn't the second parameter be enable ?
There was a problem hiding this comment.
@aboch That's correct. Let me fix it
Set the hairpin mode using the sysfs interface which looks like it is working all the way to the oldest of RHEL6.6 kernels. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the hairpin mode using the sysfs interface which
looks like it is working all the way to the oldest
of RHEL6.6 kernels.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com