Skip to content

Commit

Permalink
docker: detect defaultNetworkMtu from default route
Browse files Browse the repository at this point in the history
Docker-DCO-1.1-Signed-off-by: Johan Euphrosine <proppy@google.com> (github: google)
  • Loading branch information
proppy committed Feb 1, 2014
1 parent a446b34 commit 4d0a026
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 7 deletions.
13 changes: 11 additions & 2 deletions config.go
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
package docker

import (
"github.com/dotcloud/docker/engine"
"net"

"github.com/dotcloud/docker/engine"
"github.com/dotcloud/docker/networkdriver"
)

const (
DefaultNetworkMtu = 1500
defaultNetworkMtu = 1500
DisableNetworkBridge = "none"
)

Expand Down Expand Up @@ -53,3 +55,10 @@ func DaemonConfigFromJob(job *engine.Job) *DaemonConfig {

return config
}

func GetDefaultNetworkMtu() int {
if iface, err := networkdriver.GetDefaultRouteIface(); err == nil {
return iface.MTU
}
return defaultNetworkMtu
}
9 changes: 5 additions & 4 deletions docker/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@ package main

import (
"fmt"
"log"
"os"
"strings"

"github.com/dotcloud/docker"
"github.com/dotcloud/docker/api"
"github.com/dotcloud/docker/engine"
flag "github.com/dotcloud/docker/pkg/mflag"
"github.com/dotcloud/docker/sysinit"
"github.com/dotcloud/docker/utils"
"log"
"os"
"strings"
)

var (
Expand Down Expand Up @@ -42,7 +43,7 @@ func main() {
flInterContainerComm = flag.Bool([]string{"#icc", "-icc"}, true, "Enable inter-container communication")
flGraphDriver = flag.String([]string{"s", "-storage-driver"}, "", "Force the docker runtime to use a specific storage driver")
flHosts = docker.NewListOpts(docker.ValidateHost)
flMtu = flag.Int([]string{"#mtu", "-mtu"}, docker.DefaultNetworkMtu, "Set the containers network mtu")
flMtu = flag.Int([]string{"#mtu", "-mtu"}, docker.GetDefaultNetworkMtu(), "Set the containers network mtu")
)
flag.Var(&flDns, []string{"#dns", "-dns"}, "Force docker to use specific DNS servers")
flag.Var(&flHosts, []string{"H", "-host"}, "tcp://host:port, unix://path/to/socket, fd://* or fd://socketfd to use in daemon mode. Multiple sockets can be specified")
Expand Down
16 changes: 15 additions & 1 deletion networkdriver/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ package networkdriver
import (
"encoding/binary"
"fmt"
"github.com/dotcloud/docker/pkg/netlink"
"net"

"github.com/dotcloud/docker/pkg/netlink"
)

var (
Expand Down Expand Up @@ -100,3 +101,16 @@ func GetIfaceAddr(name string) (net.Addr, error) {
}
return addrs4[0], nil
}

func GetDefaultRouteIface() (*net.Interface, error) {
rs, err := netlink.NetworkGetRoutes()
if err != nil {
return nil, fmt.Errorf("unable to get routes: %v", err)
}
for _, r := range rs {
if r.Default {
return r.Iface, nil
}
}
return nil, fmt.Errorf("no default route")
}

0 comments on commit 4d0a026

Please sign in to comment.