Skip to content

Commit

Permalink
Merge pull request #46044 from neersighted/init_cleanup_24.0
Browse files Browse the repository at this point in the history
[24.0 backport] Upstart & sysvinit cleanup
  • Loading branch information
neersighted committed Jul 21, 2023
2 parents 52c92be + eede7f0 commit a61e2b4
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 112 deletions.
39 changes: 0 additions & 39 deletions contrib/init/sysvinit-debian/docker
Expand Up @@ -44,52 +44,17 @@ if [ ! -x $DOCKERD ]; then
exit 1
fi

check_init() {
# see also init_is_upstart in /lib/lsb/init-functions (which isn't available in Ubuntu 12.04, or we'd use it directly)
if [ -x /sbin/initctl ] && /sbin/initctl version 2> /dev/null | grep -q upstart; then
log_failure_msg "$DOCKER_DESC is managed via upstart, try using service $BASE $1"
exit 1
fi
}

fail_unless_root() {
if [ "$(id -u)" != '0' ]; then
log_failure_msg "$DOCKER_DESC must be run as root"
exit 1
fi
}

cgroupfs_mount() {
# see also https://github.com/tianon/cgroupfs-mount/blob/master/cgroupfs-mount
if grep -v '^#' /etc/fstab | grep -q cgroup \
|| [ ! -e /proc/cgroups ] \
|| [ ! -d /sys/fs/cgroup ]; then
return
fi
if ! mountpoint -q /sys/fs/cgroup; then
mount -t tmpfs -o uid=0,gid=0,mode=0755 cgroup /sys/fs/cgroup
fi
(
cd /sys/fs/cgroup
for sys in $(awk '!/^#/ { if ($4 == 1) print $1 }' /proc/cgroups); do
mkdir -p $sys
if ! mountpoint -q $sys; then
if ! mount -n -t cgroup -o $sys cgroup $sys; then
rmdir $sys || true
fi
fi
done
)
}

case "$1" in
start)
check_init

fail_unless_root

cgroupfs_mount

touch "$DOCKER_LOGFILE"
chgrp docker "$DOCKER_LOGFILE"

Expand Down Expand Up @@ -117,7 +82,6 @@ case "$1" in
;;

stop)
check_init
fail_unless_root
if [ -f "$DOCKER_SSD_PIDFILE" ]; then
log_begin_msg "Stopping $DOCKER_DESC: $BASE"
Expand All @@ -129,7 +93,6 @@ case "$1" in
;;

restart)
check_init
fail_unless_root
docker_pid=$(cat "$DOCKER_SSD_PIDFILE" 2> /dev/null || true)
[ -n "$docker_pid" ] \
Expand All @@ -139,13 +102,11 @@ case "$1" in
;;

force-reload)
check_init
fail_unless_root
$0 restart
;;

status)
check_init
status_of_proc -p "$DOCKER_SSD_PIDFILE" "$DOCKERD" "$DOCKER_DESC"
;;

Expand Down
2 changes: 1 addition & 1 deletion contrib/init/sysvinit-debian/docker.default
@@ -1,4 +1,4 @@
# Docker Upstart and SysVinit configuration file
# Docker SysVinit configuration file

#
# THIS FILE DOES NOT APPLY TO SYSTEMD
Expand Down
72 changes: 0 additions & 72 deletions contrib/init/upstart/docker.conf

This file was deleted.

0 comments on commit a61e2b4

Please sign in to comment.