Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon config validation does not detect conflicts with "common flags" #25547

Closed
dnephin opened this issue Aug 9, 2016 · 1 comment
Closed

daemon config validation does not detect conflicts with "common flags" #25547

dnephin opened this issue Aug 9, 2016 · 1 comment
Assignees
@dnephin
Labels
kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed.
Milestone
1.13.0

Comments

@dnephin
Copy link
Member

dnephin commented Aug 9, 2016

I discovered this while working on #25354

findConfigurationConflicts() only receives the daemon specific flags, not the "common flags" (debug, log-level, tls*, etc), so if a daemon is started with any of these flags, a config reload could override the previous value without the user being aware.
@dnephin dnephin added the kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. label Aug 9, 2016
@dnephin dnephin mentioned this issue Aug 9, 2016
Merged
@dnephin
Copy link
Member Author

dnephin commented Aug 9, 2016

I've got a fix for this in #25354

@dnephin dnephin self-assigned this Aug 9, 2016
@dnephin dnephin changed the title daemon config validation does not detect conflcits with "common flags" daemon config validation does not detect conflicts with "common flags" Aug 9, 2016
@thaJeztah thaJeztah added this to the 1.13.0 milestone Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnephin dnephin

Labels
kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed.
Projects
None yet
Milestone
1.13.0
Development

No branches or pull requests
2 participants
@dnephin @thaJeztah