-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin tests pull from Hub #30626
Comments
@aaronlehmann defenitely agreeing with you. I think we should do the same as we are doing for most of the image used in the integration test, i.e. pre-fetching or creating a plugin (or a bunch of them) so that we don't need to pull them. |
I also noticed that |
Another similar issue in https://jenkins.dockerproject.org/job/Docker-PRs/41506/console:
|
Should be closed by #34085 right ? |
I think so; let me close, but happy to reopen if we missed some @aaronlehmann |
Well, there's still some more to do, namely any plugins that are actually testing a subsystem are still pulled from hub. |
I noticed that the plugin integration tests install plugins from the Hub:
I see a few problems with this:
I think it would be a lot better to bake the plugins into the Docker image and serve them from a local registry.
cc @tiborvass @tonistiigi @vdemeester @anusha-ragunathan
The text was updated successfully, but these errors were encountered: