Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build failure on !linux !windows platforms #39437

Closed
novas0x2a opened this issue Jun 28, 2019 · 3 comments · Fixed by #39462
Closed

build failure on !linux !windows platforms #39437

novas0x2a opened this issue Jun 28, 2019 · 3 comments · Fixed by #39462

Comments

@novas0x2a
Copy link
Contributor

Description

#39292 broke compilation on !linux !windows build tags;

if err := realChroot(root); err != nil {
(build tag !windows) uses realChroot, defined here:
func realChroot(path string) error {
(implicit build tag linux)

I'm not sure I understand the nature of the security fix well enough to fix this myself.
Steps to reproduce the issue:

  1. go build with the build tag darwin

Describe the results you received:
github.com/docker/docker/pkg/chrootarchive/archive_unix.go:135:12: undefined: realChroot

Describe the results you expected:
working build :)

Additional information you deem important (e.g. issue happens only occasionally):
Should the call have been to chroot, not realChroot?

@thaJeztah
Copy link
Member

ping @cpuguy83

@cpuguy83
Copy link
Member

realChroot is intentional.

@cpuguy83
Copy link
Member

cpuguy83 commented Jul 3, 2019

#39462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants