Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixme: SA1019: grpc.WithDialer is deprecated #39928

Closed
thaJeztah opened this issue Sep 13, 2019 · 1 comment · Fixed by #40032
Closed

Fixme: SA1019: grpc.WithDialer is deprecated #39928

thaJeztah opened this issue Sep 13, 2019 · 1 comment · Fixed by #40032
Labels
exp/intermediate status/claimed

Comments

@thaJeztah
Copy link
Member

Tracking issue for some remaining linting issues to be fixed after #39668 is merged.

daemon/daemon.go:885:3:                               SA1019: grpc.WithDialer is deprecated: use WithContextDialer instead.  Will be supported throughout 1.x.  (staticcheck)

These warnings are currently suppressed in hack/validate/golangci-lint.yml (after #39668 is merged), so when this is fixed, those lines should be removed
@thaJeztah thaJeztah changed the title Fixme: SA1019: grpc.WithDialer is deprecated: use WithContextDialer Fixme: SA1019: grpc.WithDialer is deprecated Sep 13, 2019
@jmartin84
Copy link
Contributor

I've started to work on a PR for this.

@jmartin84 jmartin84 mentioned this issue Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate status/claimed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix grpc withdialer deprecation warning jmartin84/moby
2 participants
@jmartin84 @thaJeztah