Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: race tests are not being run #43667

Open
vvoland opened this issue May 31, 2022 · 0 comments
Open

ci: race tests are not being run #43667

vvoland opened this issue May 31, 2022 · 0 comments

Comments

@vvoland
Copy link
Contributor

vvoland commented May 31, 2022

Description
CI doesn't run race conditions tests with the "race" tag.

Noticed when working on #43666. I didn't see the build error when I was making those changes, because file has a build tag race which also makes it not being picked up by my language server.
It would probably good to have CI also run those tests, so it can detect such situations in the future.

Steps to reproduce the issue:

  1. Break the code so that the files with "race" tag can't be compiled

Describe the results you received:
CI was not mad

Describe the results you expected:
CI should be mad at me and my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants